Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable reference types for some header related classes #1068

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Enable nullable reference types for some header related classes #1068

merged 3 commits into from
Aug 27, 2024

Conversation

daniel-lerch
Copy link

@daniel-lerch daniel-lerch commented Aug 24, 2024 •
edited
Loading

This pull request enables nullable reference types for (addresses #1067):

  • Header
  • HeaderId
  • HeaderList
  • HeaderListChangedEventArgs
  • HeaderListCollection

@daniel-lerch daniel-lerch mentioned this pull request Aug 24, 2024
Open
@jstedfast
Copy link
Owner

Looks like a pretty good start, but let's rebase this on my nullable-api branch (for pr #1072) so that we can reduce #if/#else/#endif headaches by using the substitute Attribute classes that I added.

That should make this a lot easier.

@jstedfast jstedfast changed the base branch from master to nullable-api August 27, 2024 15:08
@jstedfast jstedfast merged commit cc4c3b9 into jstedfast:nullable-api Aug 27, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daniel-lerch @jstedfast